-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blocks: remove BlockIcon wrapper in multiple blocks. #22590
Conversation
Follow-up from #13324
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me here as far as my testing goes 👍
Great news! One last step: head over to your WordPress.com diff, D74154-code, and commit it. Thank you! |
r239726-wpcom |
Follow-up from #13324
Changes proposed in this Pull Request:
All of these are passed as an icon prop to Placeholder components, which accepts a string, or ReactElement.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
BlockIcon
component in mediaPlaceholders #12160)