Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js package generator Add test runner to dev dependencies #21591

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

leogermani
Copy link
Contributor

Changes proposed in this Pull Request:

  • Fixes the package.json file created by jetpack generator

Jetpack product discussion

#21563 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Generate a JS package and make sure test runner ends up under devDependencies in packages.json

@leogermani leogermani added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Tools] Development CLI The tools/cli to assist during JP development. labels Oct 29, 2021
@leogermani leogermani requested a review from anomiex October 29, 2021 19:09
@leogermani leogermani self-assigned this Oct 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@leogermani
Copy link
Contributor Author

@anomiex I also wanted to remove yoast polyfills from composer.json but js-packages use the same skeleton file so we'll have to change things a bit more if we want that. (Do we really need composer.json there? Just for the changelogger?)

@anomiex
Copy link
Contributor

anomiex commented Nov 1, 2021

We need a composer.json because all our tooling is based around using that file to identify that the project really is a project and using it to configure CI and stuff.

Ideally we'd let a file in tools/cli/skeletons/js-packages/composer.json override tools/cli/skeletons/common/composer.json, but right now it's the other way around. Or we could partially undo #21436 to instead have it delete composerJson['require-dev']['yoast/phpunit-polyfills'];

@anomiex anomiex added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 1, 2021
@leogermani leogermani enabled auto-merge (squash) November 8, 2021 14:05
@leogermani leogermani merged commit 9e9c1ec into master Nov 8, 2021
@leogermani leogermani deleted the fix/generate-js-package-dependency branch November 8, 2021 14:16
@github-actions github-actions bot removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 8, 2021
davidlonjon added a commit that referenced this pull request Nov 9, 2021
# By renovate[bot] (3) and others
# Via GitHub
* master:
  Update dependency preact to v10.5.15 (#21635)
  Search: Migrate helper classes to standalone package (#21552)
  Release script: fix small typo (#21675)
  Update babel monorepo (#21668)
  Lock file maintenance (#21664)
  E2E tests: clean unused dependencies (#21639)
  Create JS Config package (#21592)
  Use webpack config JS package in Jetpack (#21581)
  add test runner to dev dependencies (#21591)
  Pexels Integration: Make the initial image search for example query run only once (#21641)
  Boost: make progress bar corners round on small screens (#21626)
  Full Sync :: limit to contributors and above (#21648)
  Sync Checksums : limit users based on user_level (#21645)
  Storybook: add Jetpack Spinner (#21511)
  Contact Info and Map widget: widget deprecation (#21554)
  Use webpack config js package in everything except Jetpack (#21580)

# Conflicts:
#	pnpm-lock.yaml
#	projects/plugins/boost/package.json
davidlonjon added a commit that referenced this pull request Nov 9, 2021
* master: (24 commits)
  Update dependency preact to v10.5.15 (#21635)
  Search: Migrate helper classes to standalone package (#21552)
  Release script: fix small typo (#21675)
  Update babel monorepo (#21668)
  Lock file maintenance (#21664)
  E2E tests: clean unused dependencies (#21639)
  Create JS Config package (#21592)
  Use webpack config JS package in Jetpack (#21581)
  add test runner to dev dependencies (#21591)
  Pexels Integration: Make the initial image search for example query run only once (#21641)
  Boost: make progress bar corners round on small screens (#21626)
  Full Sync :: limit to contributors and above (#21648)
  Sync Checksums : limit users based on user_level (#21645)
  Storybook: add Jetpack Spinner (#21511)
  Contact Info and Map widget: widget deprecation (#21554)
  Use webpack config js package in everything except Jetpack (#21580)
  Boost: Fix the official name to the JavaScript word reference (#21638)
  tools: Allow extra spaces in next-version tags (#21647)
  Publicize: always add an alt text to Open Graph Images (#21520)
  js-tools: Add missing eslint plugin dep (#21642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tools] Development CLI The tools/cli to assist during JP development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants