Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: fix some interface strings are not being localized #20850

Closed
wants to merge 16 commits into from

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Aug 27, 2021

Fixes #20520

Changes proposed in this Pull Request:

Inline translations before enqueuing the main payload to make sure translations for lazy-loaded payloads are available.

TODO: test on WPCOM

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Open your local site with Jetpack Search subscription
  • Caculate signature php -r "echo md5('_inc/build/instant-search/jp-search.chunk-main-payload-a7fe2cd7399a1c7473a1.js');"
    • You need to replace the file name with your local one
    • Please NOTE: no min should be in the file name even that is the case
  • Change the translation file name, e.g. from jetpack-fr_FR-MD5.json to jetpack-fr_FR-83c2622273c4d246d24c018dd16b3510.json, 83c2622273c4d246d24c018dd16b3510 is the md5 you get from the previous step.
  • Ensure everything is translated, especially the marked ones.

image

@kangzj kangzj added [Focus] i18n Internationalization / i18n, adaptation to different languages [Feature] Search For all things related to Search Instant Search labels Aug 27, 2021
@kangzj kangzj self-assigned this Aug 27, 2021
@kangzj kangzj requested a review from a team as a code owner August 27, 2021 03:51
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kangzj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D66019-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 27, 2021
@kangzj kangzj added [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 27, 2021
@kangzj kangzj force-pushed the fix/search-translation branch from a4f96c9 to 8ea59f3 Compare August 31, 2021 05:08
@kangzj kangzj force-pushed the fix/search-translation branch from 36210c8 to e7adc42 Compare August 31, 2021 23:06
@kangzj
Copy link
Contributor Author

kangzj commented Sep 3, 2021

This is closed in favour of #20926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Focus] i18n Internationalization / i18n, adaptation to different languages [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Search: some interface strings are not being localized
2 participants