-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: fix some interface strings are not being localized #20850
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
a4f96c9
to
8ea59f3
Compare
36210c8
to
e7adc42
Compare
This is closed in favour of #20926 |
Fixes #20520
Changes proposed in this Pull Request:
Inline translations before enqueuing the main payload to make sure translations for lazy-loaded payloads are available.
TODO: test on WPCOM
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions:
php -r "echo md5('_inc/build/instant-search/jp-search.chunk-main-payload-a7fe2cd7399a1c7473a1.js');"
min
should be in the file name even that is the casejetpack-fr_FR-MD5.json
tojetpack-fr_FR-83c2622273c4d246d24c018dd16b3510.json
,83c2622273c4d246d24c018dd16b3510
is the md5 you get from the previous step.