Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Menu: Sync styles from prototype #18039

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

obenland
Copy link
Member

@obenland obenland commented Dec 9, 2020

This is a follow-up to @cpapazoglou's comment here:

I suggest merging it and iterating more on:

  • Mobile menu open / close
  • Site Switcher menu item missing

#17629 (review)

Changes proposed in this Pull Request:

  • Sync CSS changes from wpcom proptype

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to '..'

Proposed changelog entry for your changes:

  • None needed.

@obenland obenland added [Status] In Progress Touches WP.com Files [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations labels Dec 9, 2020
@obenland obenland requested a review from cpapazoglou December 9, 2020 18:57
@obenland obenland self-assigned this Dec 9, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello obenland! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D54046-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

Scheduled Jetpack release: December 10, 2020.
Scheduled code freeze: December 3, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against d4e44b7

@obenland
Copy link
Member Author

obenland commented Dec 9, 2020

@cpapazoglou Could you please advise on which styles are needed and which can go (if any)? And if the Site Switcher issue you mentioned is still an issue?

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably iterate on the colors as a result of the color-schemes feature but right now LGTM! Let's merge it and start deploying in wpcom and deleting the duplicates found there so that we have a canonical reference! Thanks!

@obenland obenland merged commit 7f34eec into master Dec 11, 2020
@obenland obenland deleted the update/admin-menu-styles branch December 11, 2020 21:53
@github-actions github-actions bot added this to the 9.3 milestone Dec 11, 2020
@obenland
Copy link
Member Author

r218228-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants