Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified error message for non-writable options table. #17767

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

sergeymitr
Copy link
Contributor

@sergeymitr sergeymitr commented Nov 10, 2020

Changes proposed in this Pull Request:

When the wp_options table is not writeable, connecting Jetpack will result in the error Verification secrets not found.
This PR clarifies the error, informing the user that they need to confirm the options table is writable.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Disconnect Jetpack (if connected).
  2. Remove AUTO_INCREMENT from the wp_options table:
ALTER TABLE wp_options CHANGE option_id option_id bigint(20) unsigned NOT NULL;
  1. Try to connect Jetpack.
  2. The "Set up Jetpack" page should be reloaded, the error message "Could not save secrets. Please confirm that the options table is writable." should show up.

Before:
Screen Shot 2020-11-10 at 3 21 55 PM

After:
Screen Shot 2020-11-11 at 1 35 30 PM

Proposed changelog entry for your changes:

  • Displaying a clarified error message when the options table is not writable.

When the `wp_options` table is not writeable, connecting Jetpack will result in the error `Verification secrets not found`.

This commit clarifies the error, informing the user that they need to confirm the options table is writable.
@sergeymitr sergeymitr added [Status] In Progress Connect Flow Connection banners, buttons, ... labels Nov 10, 2020
@sergeymitr sergeymitr added this to the 9.2 milestone Nov 10, 2020
@sergeymitr sergeymitr self-assigned this Nov 10, 2020
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Nov 10, 2020
@jetpackbot
Copy link

jetpackbot commented Nov 10, 2020

Scheduled Jetpack release: December 1, 2020.
Scheduled code freeze: November 23, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17767

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 88fa36c

@sergeymitr sergeymitr added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 10, 2020
Making the error message more explicit and clear.
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, and the only change since Jeremy's review was a wording adjustment he suggested.

@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 12, 2020
@sergeymitr sergeymitr merged commit 2077bf2 into master Nov 12, 2020
@sergeymitr sergeymitr deleted the add/failed-options-error-notice branch November 12, 2020 23:28
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 12, 2020
anomiex added a commit that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connect Flow Connection banners, buttons, ... [Status] Needs Package Release This PR made changes to a package. Let's update that package now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants