-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified error message for non-writable options table. #17767
Conversation
When the `wp_options` table is not writeable, connecting Jetpack will result in the error `Verification secrets not found`. This commit clarifies the error, informing the user that they need to confirm the options table is writable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME
to true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
Verify that the changes are compatible with the plugins that use the connection package.
- WooCommerce Payments
- Jetpack Boost
- Previous versions of Jetpack
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
Scheduled Jetpack release: December 1, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17767 Thank you for the great PR description! When this PR is ready for review, please apply the |
Making the error message more explicit and clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward, and the only change since Jeremy's review was a wording adjustment he suggested.
Changes proposed in this Pull Request:
When the
wp_options
table is not writeable, connecting Jetpack will result in the errorVerification secrets not found
.This PR clarifies the error, informing the user that they need to confirm the options table is writable.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
AUTO_INCREMENT
from thewp_options
table:Before:
After:
Proposed changelog entry for your changes: