Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required Review: Update team to Approvers #17307

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Required Review: Update team to Approvers #17307

merged 1 commit into from
Sep 30, 2020

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 29, 2020

As part of p9dueE-1T9-p2, we are updating the GitHub team for the reuired review to the "Jetpack Approvers" team.

Changes proposed in this Pull Request:

  • Update team from Crew to Approvers

Jetpack product discussion

p9dueE-1T9-p2

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • I'm not sure we can test it in PR form or if it has to be merged. Basically, ensure that any of us can still approve a PR.

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Sep 29, 2020
@kraftbj kraftbj added this to the 9.1 milestone Sep 29, 2020
@kraftbj kraftbj requested a review from dereksmart September 29, 2020 20:40
@kraftbj kraftbj self-assigned this Sep 29, 2020
@jetpackbot
Copy link

Scheduled Jetpack release: October 6, 2020.
Scheduled code freeze: September 29, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17307

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against b64d78f

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! Actions GitHub actions used to automate some of the work around releases and repository management and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 30, 2020
@kraftbj kraftbj merged commit 93a46a0 into master Sep 30, 2020
@kraftbj kraftbj deleted the update/required-review-team branch September 30, 2020 14:11
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees

@kraftbj kraftbj

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Type] Janitorial
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kraftbj @jetpackbot @jeherve @matticbot