Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurring Payments: Keep custom text on plan change #16148

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Recurring Payments: Keep custom text on plan change #16148

merged 1 commit into from
Jun 15, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jun 12, 2020

Changes proposed in this Pull Request:

Ensures any custom text entered in a Recurring Payments button is preserved when plan changes.

Before After
Jun-12-2020 13-52-23 Jun-12-2020 13-45-28

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Recurring Payments is an existing feature of Jetpack.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Insert a Recurring Payments block.
  • Select a plan.
  • Makes sure the button label changes to <Plan Amount> Contribution.
  • Change the plan.
  • Makes sure the button label changes to <New Plan Amount> Contribution.
  • Change the button label to a custom text such as "Subscribe".
  • Change the plan.
  • Makes sure the custom text previously entered is preserved.

Proposed changelog entry for your changes:

Recurring Payments: Keep custom text on plan change

@mmtr mmtr added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] Payment Button aka Recurring Payments labels Jun 12, 2020
@mmtr mmtr requested review from a team June 12, 2020 11:58
@mmtr mmtr self-assigned this Jun 12, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello mmtr! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D44875-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

Howdy! The Jetpack team has disappeared for a few days to recharge our batteries. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back on Monday, June 15 to look at your work! Thank you for your understanding.

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16148

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against 593dd65

@mmtr mmtr mentioned this pull request Jun 12, 2020
Merged
kwight
kwight approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@kwight kwight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful 🚀

mdbitz
mdbitz approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@mdbitz mdbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the custom text is maintained, Crew Review Approved

@mdbitz mdbitz added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 15, 2020
@mmtr mmtr merged commit f7874f3 into master Jun 15, 2020
@mmtr mmtr deleted the update/recurring-payments-keep-text branch June 15, 2020 15:07
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 15, 2020
@kraftbj kraftbj added this to the 8.7 milestone Jun 15, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Jun 15, 2020

r209051-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwight kwight kwight approved these changes

@mdbitz mdbitz mdbitz approved these changes

Assignees

@mmtr mmtr

Labels
[Block] Payment Button aka Recurring Payments Touches WP.com Files
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
7 participants
@mmtr @matticbot @jetpackbot @kraftbj @kwight @mdbitz @jeherve