Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Block: Add documentation #15934

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Button Block: Add documentation #15934

merged 1 commit into from
Jun 22, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented May 26, 2020

Changes proposed in this Pull Request:

  • Add documentation for the Button block.

This already includes changes introduced in #15918 and #15931.

Proposed changelog entry for your changes:

  • Button block: Add documentation

@Copons Copons added [Type] Janitorial [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Needs Team Review [Block] Button labels May 26, 2020
@Copons Copons requested review from apeatling and a team May 26, 2020 16:18
@Copons Copons self-assigned this May 26, 2020
@jetpackbot
Copy link
Collaborator

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-15934

Generated by 🚫 dangerJS against ba60546

apeatling
apeatling approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the docs!

@Copons Copons mentioned this pull request May 26, 2020
Merged
@glendaviesnz glendaviesnz added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels May 27, 2020
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 28, 2020
@kraftbj kraftbj added this to the 8.7 milestone May 28, 2020
@Copons
Copy link
Contributor Author

Copons commented May 29, 2020

Thanks for the reviews!
Just FYI: I'm delaying this merge until #15918 and #15931 are in.

@Copons Copons merged commit 3d97311 into master Jun 22, 2020
@Copons Copons deleted the add/button-block-docs branch June 22, 2020 10:37
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@apeatling apeatling apeatling approved these changes

Assignees

@Copons Copons

Labels
[Block] Button [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Janitorial
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
7 participants
@Copons @jetpackbot @kraftbj @apeatling @jeherve @glendaviesnz @matticbot