Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Blocks: Try using the new shared Button component #14931

Closed

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Mar 10, 2020

See #14935

Examples for #14920, one block per commit.

  • Eventbrite 777dcdf
  • Revue 9e54614
  • Contact Form 36f8396
  • Calendly 787ed48

Note: for simplicity, I haven't added any deprecations/migrations, so this won't work on old blocks.

@Copons Copons added [Status] In Progress [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Mar 10, 2020
@Copons Copons requested a review from a team March 10, 2020 13:25
@Copons Copons self-assigned this Mar 10, 2020
@Copons Copons force-pushed the try/another-block-button-examples branch from 099e6af to 78f9af8 Compare March 11, 2020 17:46
@Copons Copons force-pushed the try/another-block-button-examples branch from 78f9af8 to 787ed48 Compare March 11, 2020 17:52
@Copons Copons force-pushed the try/another-block-button branch 2 times, most recently from c033ce8 to 50ed035 Compare April 2, 2020 11:58
@Copons Copons closed this Apr 22, 2020
@Copons Copons deleted the try/another-block-button-examples branch April 22, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate the Button component implementations for use in blocks
3 participants