Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "OpenTable & Calendly: Improve save functions by wrapping links in divs" #14793

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Revert "OpenTable & Calendly: Improve save functions by wrapping links in divs" #14793

merged 1 commit into from
Feb 25, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 25, 2020 •
edited
Loading

Reverts #14754

Internal reference: p1582631245057200-slack-jetpack-crew

We'll take a different approach on this.

Testing instructions:

  • Add a Calendly and OpenTable block to a page
  • Make sure they still work.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] OpenTable [Block] Calendly labels Feb 25, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 25, 2020
@jeherve jeherve requested review from scruffian and a team February 25, 2020 13:28
@jeherve jeherve self-assigned this Feb 25, 2020
@jetpackbot
Copy link

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against aae885a

scruffian
scruffian approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zinigor
zinigor approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a legit revert, LGTM!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 25, 2020
@jeherve jeherve merged commit 5a740a0 into master Feb 25, 2020
@jeherve jeherve deleted the revert-14754-update/save-for-calendly-and-opentable branch February 25, 2020 14:07
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 25, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
[not verified] Revert "OpenTable & Calendly: Improve save functions b…
d07dfda 
…y wrappi… (#14793)

This reverts commit 18d1f9c.
@jeherve
Copy link
Member Author

jeherve commented Feb 25, 2020

Cherry-picked to branch-8.3 in d07dfda

@jeherve jeherve mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

@scruffian scruffian scruffian approved these changes

Assignees

@jeherve jeherve

Labels
[Block] Calendly [Block] OpenTable [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @scruffian @zinigor @matticbot