Map Block: Update mapbox-gl dependency to 1.6.1

[creativecoder]

Fixes #14183

Changes proposed in this Pull Request:

• Update Mapbox GL js library to 1.6.1

This update opts users into Mapbox's new map load pricing model

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• Updates the existing map block

Testing instructions:

• Insert a map block and add an API key
• Load the map on the front end of the site
• When you pan/zoom the map, see that the network requests to get map tiles include a sku value (https://github.com/mapbox/mapbox-gl-js/blob/master/CHANGELOG.md#100)
• Check the Mapbox statistics for the api key you are using and see that map loads are being tracked (instead of tile loads)

Proposed changelog entry for your changes:

• Map Block: Update Mapbox GL library to opt into map load based billing

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello creativecoder! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38195-code before merging this PR. Thank you!

[jetpackbot]

	Warnings
⚠️	The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 02a7d77

[creativecoder]

@jeffersonrabb Checking if you see any issues with upgrading this.

Also, please let us know if there's specific things we should check for the AMP map block.

[creativecoder]

I've looked through the Mapbox GL library changelog and don't see anything obvious in our implementation that needs to be updated, but need further testing to be sure.

[jeffersonrabb]

Checking if you see any issues with upgrading this.

Looks good to me! I did some before and after testing with a variety of features and everything seems to be working fine.

[jeffersonrabb]

Also, please let us know if there's specific things we should check for the AMP map block.

The AMP implementation is done in a way that has nothing to do with Javascript. Each Map block is rendered as an AMP iFrame, with a src of the current URL with two query parameters conveying post ID and ordinal of the block (e.g. this one is the 3rd Map block in this post). That URL will render a "fake" non-AMP web page containing nothing but the Map block. Therefore, anything that works in a non-AMP context should work the same in AMP, regardless of Javascript changes.

[Copons]

This looks good to me too!
I can't see any noticeable difference than before, and I can see the sku param on the new requests.

Just one thing: I don't see any "map load" tracking stats in my Mapbox account. It might be a matter of time though, but it has been almost an hour now since I started testing.
Scratch that, they finally appeared. 🙂

[creativecoder]

Looks like this is ready to go, then, from my perspective. @jeherve Is there anything we should do to update users about the change, besides an entry in the changelog?

[jeherve]

This looks good to me and should be good to merge.

A changelog entry should be enough imo.

[jeherve]

Cherry-picked to branch-8.2 in d19765a

[jeherve]

r202327-wpcom