Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring: register Sharing menu page if it has not been registered #13799

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Keyring: register Sharing menu page if it has not been registered #13799

merged 2 commits into from
Oct 28, 2019

Commits on Oct 22, 2019

  1. Keyring: register Sharing menu page if it has not been registered 

    Fixes #13732

When neither Publicize, Sharing, Likes, or Comment Likes are active, nothing in Jetpack registers the Sharing menu that the Keyring service relies on.
This checks if the menu exists and registers it (although without UI since we don't need one for Keyring services that are not Publicize)
    @jeherve
    jeherve committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    2ec9737 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Use higher priority so we don't run this earlier than needed. 

    see https://github.com/Automattic/jetpack/pull/13799/files#r338800374
    @jeherve
    jeherve committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ac9dfc4 View commit details
    Browse the repository at this point in the history