-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calypsoify: Add support for switching to Classic when iframing the block editor. #12163
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this worked wonderfully for me!
Note that I had to use a different browser to test, because my usual browser was loading a cached version of the wpcom-block-editor/common.js
script don't including the required latest changes we added earlier this week in Automattic/wp-calypso#32421 / D27149-code.
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
This should need a rebase now. |
ab6bcd6
to
f5ddad1
Compare
Rebased and ready to go again – thanks @jeherve ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked well in my tests. I only had 2 comments, that may not be blocking. I'll let you judge.
When using WordPress.com to edit a WordPress.com site, we give a menu option in the block editor to easily switch to the Calypso editor. With upcoming support for editing Jetpack sites with the block editor on WordPress.com, this PR will give the same option for Jetpack users.
Note that the changes to
modules/calypsoify/class.jetpack-calypsoify.php
could have been a little simpler, but these changes bring it more in line with theCalypsoify
class active on WP.com; knowing we'll be faced with bringing the two more in sync in the future, keeping them as similar as possible for now seems the prudent approach.Testing instructions:
http://calypso.localhost:3000/block-editor/post/:JPsite
(JPSite
being your test site with this Jetpack repo installed).http://calypso.localhost:3000/block-editor/post/:JPsite
.Proposed changelog entry for your changes: