Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg blocks: Fix CSS for Form and Contact Info blocks #12156

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Gutenberg blocks: Fix CSS for Form and Contact Info blocks #12156

merged 4 commits into from
Apr 30, 2019

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Apr 25, 2019 •
edited
Loading

Add a bunch of small CSS tweaks to make the Form and Contact Info blocks more compliant with tight editor areas (e.g. as part of a Column block)

Changes proposed in this Pull Request:

  • Remove padding for Parent blocks (Form and Contact Info)
  • Fix word-break on small screens for the required label/toggle control

Testing instructions:

  • Create a new post/page
  • Add a Contact Info block and a Form block
  • Can you still easily select the parent block?
  • Now add a Column block. Add a Contact Info in 1 column and a Form in a 2nd column.
  • How does that look?
Screenshots:

Before:
Screenshot 2019-04-25 at 15 51 37 (2)

After:
Screenshot 2019-04-25 at 15 52 44 (2)

Proposed changelog entry for your changes:

  • Remove padding for Form and Contact Info blocks
  • Fix word-break on small screens for the Form block

@thomasguillot
Gutenberg blocks: Fix CSS for Form and Contact Info blocks
6ef6189 
* Reduce the right/left padding for Parent blocks.
* Fix word-break on small screens for the required toggle control
@thomasguillot thomasguillot added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Contact Info labels Apr 25, 2019
@thomasguillot thomasguillot requested review from simison, scruffian and a team April 25, 2019 14:56
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello thomasguillot! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27415-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 25, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against cc77327

@matticbot
Copy link
Contributor

thomasguillot, Your synced wpcom patch D27415-code has been updated.

simison
simison previously approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving it!

@matticbot
Copy link
Contributor

thomasguillot, Your synced wpcom patch D27415-code has been updated.

simison
simison previously approved these changes Apr 25, 2019
View reviewed changes
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 26, 2019
jeherve
jeherve previously approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@kraftbj kraftbj added this to the 7.3 milestone Apr 29, 2019
@kraftbj kraftbj dismissed stale reviews from jeherve and simison via cc77327 April 30, 2019 14:47
@matticbot
Copy link
Contributor

thomasguillot, Your synced wpcom patch D27415-code has been updated.

@kraftbj
Copy link
Contributor

kraftbj commented Apr 30, 2019

r191105-wpcom

@kraftbj kraftbj merged commit 47e8ea8 into master Apr 30, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 30, 2019
@kraftbj kraftbj deleted the fix/gutenberg-blocks-css branch April 30, 2019 14:55
kraftbj added a commit that referenced this pull request Apr 30, 2019
@kraftbj
CL: #12156
bdfd1b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@simison simison simison left review comments

@scruffian scruffian Awaiting requested review from scruffian

Assignees
No one assigned
Labels
[Block] Contact Info [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Status] Tested on WP.com Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
6 participants
@thomasguillot @matticbot @jetpackbot @kraftbj @simison @jeherve