Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Hide section subheadings when searching for features #12155

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

scottsweb
Copy link
Contributor

@scottsweb scottsweb commented Apr 25, 2019

Since the module search might throw results that are not strictly encompassed in the current tab, the titles should be adjusted to provide context lost by the removed navigation.

Fixes #12091

Changes proposed in this Pull Request:

  • Swap the subheadings to match the section navigation during a module search

Testing instructions:

  • Go to Jetpack settings
  • Click on the magnifying glass to start searching
  • type something that actually has results, like "search"
  • check the subheadings correctly separate the sections and make sense

Before:

Screenshot 2019-04-25 at 15 54 13

After:

Screenshot 2019-04-25 at 15 41 16

Proposed changelog entry for your changes:

  • Clearer headings when searching for modules in the settings section

@scottsweb scottsweb added [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Apr 25, 2019
@scottsweb scottsweb requested a review from a team April 25, 2019 14:32
@scottsweb scottsweb added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Apr 25, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 25, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against def17e7

@scottsweb scottsweb added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Apr 25, 2019
@MichaelArestad
Copy link
Contributor

Tested. This is excellent. Once crew reviews, I would say this is ready to merge.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 26, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my tests. Merging!

@jeherve jeherve merged commit d10d568 into master Apr 26, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 26, 2019
@jeherve jeherve deleted the update/hide-section-titles-on-search branch April 26, 2019 14:11
kraftbj added a commit that referenced this pull request Apr 26, 2019
kraftbj added a commit that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: remove/replace tab subheading when searching
6 participants