Google Video: retire shortcode. #12154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The Google Video Service is not available anymore, their embeds don't work anymmore, and redirects from Google Video to Youtube don't seem to work anymore either. Let's consequently retire this embed for good, and add it to the list of unavailable shortcodes. Test Plan: * Add the following to your site: `[googlevideo=http://video.google.com/googleplayer.swf?docId=-6006084025483872237]` * Make sure you see a message that the service is not supported anymore on the frontend. Tags: #touches_jetpack_files Differential Revision: D27408-code This commit syncs r190859-wpcom.
jeherve
added
[Feature] Shortcodes / Embeds
[Status] Needs Review
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
kraftbj
approved these changes
Apr 25, 2019
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D27408-code
This commit syncs r190859-wpcom.
Changes proposed in this Pull Request:
The Google Video Service is not available anymore, their embeds don't work anymmore, and redirects from Google Video to Youtube don't seem to work anymore either.
Let's consequently retire this embed for good, and add it to the list of unavailable shortcodes.
Testing instructions:
[googlevideo=http://video.google.com/googleplayer.swf?docId=-6006084025483872237]Proposed changelog entry for your changes: