Check status of dev mode in navigation component and hide plan pages

[scottsweb]

Check status of dev mode in navigation component and hide plan pages if dev mode is turned on. This was reported in #12119.

Fixes #12119

My first PR against Jetpack so feedback is encouraged.

Changes proposed in this Pull Request:

• Load the dev mode state from the store
• Conditionally check the prob and render navigation accordingly

Testing instructions:

• Go to wp-admin/admin.php?page=jetpack#/dashboard
• Define define( 'JETPACK_DEV_DEBUG', true );
• Check the plan related navigation menu items are hidden when enabled.

Before:

After:

Proposed changelog entry for your changes:

• Hide plan admin pages when debug mode is enabled

[eliorivero]

Great work @scottsweb! Left some comments. Feel free to ping me on Slack for any questions 👍

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against f53bd1a

[eliorivero]

Code is good!
One more question and cc @MichaelArestad too, are we really hiding the My Plan tab?

We currently have content there explaining that the site is in Dev Mode. That said, all those buttons are totally broken, they go nowhere.

If we hide it (and I agree with that) we should remove this portion of code that displays the header for My Plan when the site is in Dev Mode since it will never be used again.

https://github.com/Automattic/jetpack/blob/master/_inc/client/my-plan/my-plan-header.jsx#L127-L149

[eliorivero]

🐑

[jeherve]

Works well in my tests. 👍