Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JITMs to be translated. #12098

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Allow JITMs to be translated. #12098

merged 1 commit into from
Apr 19, 2019

Conversation

withinboredom
Copy link
Contributor

Changes proposed in this Pull Request:

Testing instructions:

  • Create a new Jetpack site with a non-english language with this patch
  • Ensure there's no plan
  • Navigate to the comments section
  • See a jitm about akismet in non-english

Proposed changelog entry for your changes:

  • Translate Just In Time messages

@withinboredom withinboredom added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Apr 19, 2019
@withinboredom withinboredom requested a review from a team April 19, 2019 10:05
@withinboredom withinboredom self-assigned this Apr 19, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against ea740eb

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Focus] i18n Internationalization / i18n, adaptation to different languages and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 19, 2019
jeherve
jeherve approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@jeherve jeherve added this to the 7.3 milestone Apr 19, 2019
@withinboredom
Copy link
Contributor Author

I can't remember: do I merge this or will someone else?

@jeherve
Copy link
Member

jeherve commented Apr 19, 2019

The button is green, so you can go ahead. I'll leave it to you! :)

@withinboredom withinboredom merged commit c3eb409 into master Apr 19, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 19, 2019
@withinboredom withinboredom deleted the add/jitm-translations branch April 19, 2019 11:01
kraftbj added a commit that referenced this pull request Apr 26, 2019
@kraftbj
CL: #12098 and moving some things around.
0588aa4
kraftbj added a commit that referenced this pull request Apr 30, 2019
@kraftbj
CL: #12098 and moving some things around.
df059d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@withinboredom withinboredom

Labels
[Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@withinboredom @jetpackbot @jeherve @kraftbj @matticbot