Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Enable Likes and Sharing extension in production #12032

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Apr 12, 2019

We've had a call for testing up for a week and the only issue found is one with CPTs, for which I have a proposed fix in #12031. I think this is good to go especially once #12031 lands (though also I don't think the CPT issue is a blocker as long as we get it in for the next release).

Changes proposed in this Pull Request:

  • Move the Likes and Sharing extensions into production!

Testing instructions:

Proposed changelog entry for your changes:

  • Enable Likes and Sharing metaboxes as a Gutenberg extension

@codebykat codebykat added [Feature] Sharing Post sharing, sharing buttons [Feature] Likes [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 12, 2019
@codebykat codebykat requested review from a team April 12, 2019 07:02
@codebykat codebykat self-assigned this Apr 12, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello codebykat! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26858-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 755e99d

@obenland
Copy link
Member

@kraftbj It looks like Jetpackbot's schedule information diverges from +jetpackp2. Which one is the source of truth?

@jeherve
Copy link
Member

jeherve commented Apr 15, 2019

@obenland +jetpackp2 is the right one. I've updated the milestone date here on GitHub so jetpackbot will know best next time :)

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go whenever you are ready!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 15, 2019
@jeherve jeherve added this to the 7.3 milestone Apr 15, 2019
@codebykat codebykat merged commit 99e423d into master Apr 16, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 16, 2019
@codebykat codebykat deleted the add/likes-and-sharing-extension-in-prod branch April 16, 2019 18:57
kraftbj added a commit that referenced this pull request Apr 26, 2019
kraftbj added a commit that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Likes [Feature] Sharing Post sharing, sharing buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants