Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: add translation context to block search keywords #12023

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Blocks: add translation context to block search keywords #12023

merged 1 commit into from
Apr 11, 2019

Conversation

simison
Copy link
Member

@simison simison commented Apr 11, 2019

Add translation context to block search keywords.

Just a minor change to test new build-deploy workflow for wpcom.

Changes proposed in this Pull Request:

  • Add translators context for block search keywords
  • Add map block 3rd keyword: "navigation" (3 is the maximum)

Testing instructions:

Do blocks still show up with these keywords in the block picker?

Proposed changelog entry for your changes:

@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] i18n Internationalization / i18n, adaptation to different languages [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 11, 2019
@simison simison requested review from a team April 11, 2019 15:23
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26799-code before merging this PR. Thank you!

jeherve
jeherve approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 11, 2019
@jeherve jeherve added this to the 7.3 milestone Apr 11, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 1ff4173

@simison simison merged commit b22fd2d into master Apr 11, 2019
@simison simison deleted the update/context-block-keywords branch April 11, 2019 15:40
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 11, 2019
kraftbj added a commit that referenced this pull request Apr 26, 2019
@kraftbj
CL: #12023
61244aa
kraftbj added a commit that referenced this pull request Apr 30, 2019
@kraftbj
CL: #12023
b5124ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] i18n Internationalization / i18n, adaptation to different languages Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@simison @matticbot @jetpackbot @jeherve @kraftbj