Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions: Add block editor extensions source #11685

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Extensions: Add block editor extensions source #11685

merged 2 commits into from
Mar 26, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 26, 2019 •
edited by sirreal
Loading

Adds the block editor extensions source and tooling from #11633 and #11639.

Initially reverted to allow a clean 7.2 release.

See #11682, #11633, #11639

Changes proposed in this Pull Request:

  • Adds tools and block source back to Jetpack

Testing instructions:

  • n/a

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Mar 26, 2019
@kraftbj kraftbj added this to the 7.3 milestone Mar 26, 2019
@kraftbj kraftbj requested a review from a team March 26, 2019 15:38
@kraftbj kraftbj added [Status] In Progress and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Mar 26, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against ccc5e82

@sirreal sirreal force-pushed the add/gutenblocks-tools-and-source branch from e2cd0de to 7fc90d1 Compare March 26, 2019 16:06
@sirreal sirreal changed the title Revert "Gutenblocks: Revert move to JP (#11682)" Extensions: Add block editor extensions source Mar 26, 2019
@sirreal sirreal requested a review from a team March 26, 2019 16:08
@sirreal sirreal added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Mar 26, 2019
@sirreal
Copy link
Member

sirreal commented Mar 26, 2019 •
edited
Loading

I've pulled blocks changes from Automattic/wp-calypso@e8d02c0

sirreal
sirreal approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can land this any time 👍

brbrr
brbrr approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2019
@kraftbj kraftbj merged commit 43f0264 into master Mar 26, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 26, 2019
@kraftbj kraftbj deleted the add/gutenblocks-tools-and-source branch March 26, 2019 16:48
kraftbj added a commit that referenced this pull request Apr 30, 2019
@kraftbj
CL: #11685
70064b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

@brbrr brbrr brbrr approved these changes

Assignees

@sirreal sirreal

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@kraftbj @jetpackbot @sirreal @brbrr @matticbot