-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Allow composing block editor posts on WordPress.com. #11354
Conversation
This is an automated check which relies on |
Noting that this still in progress, but will proceed attempting to use |
300600d
to
3589642
Compare
Question: Is this something you're aiming for 7.2 (April release) or just whenever it is ready? |
@kraftbj There's no ETA yet, this is more experimental |
90afa05
to
3df533c
Compare
Noting that I stumbled across #7623 today; so if we go ahead with this, we'll need to consider overlapping concerns. |
2d18bdc
to
39bf216
Compare
c4fe9bf
to
617cb2f
Compare
617cb2f
to
d599c6d
Compare
Could you update the testing instructions? I can't find the setting and the linked wp.com phab is closed. Thank you! |
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
Outdated
Show resolved
Hide resolved
What happens if the user on the Jetpack site has the Classic Editor active? (If it's a problem, and needs fixing in Jetpack, it probably deserves a separate PR.) |
Yes, that is something that's being explored in Automattic/wp-calypso#32047 |
Also adds documentation about appropriate return values.
`__DIR__` is a PHP 5.3 constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
Added to the 7.3 Changelog in 7514c5f |
This PR allows WordPress.com users to access the block editor for Jetpack sites on Calypso via an iframe.
See phase 2 notes at p3fqKv-6Hh-p2.
Testing Instructions
jetpack/gutenframe
flag on testing environments, beingwpcalypso
,horizon
, anddevelopment
)./block-editor/post/:yourJetpackDomain
.sameorigin
error in the console).wp-admin/admin.php?page=jetpack_modules
(click "WordPress.com Block Editor Iframe" towards the bottom)./block-editor/post/:yourJetpackDomain
again.Proposed changelog entry for your changes: