Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate-like: Update history and react-router deps #10929

Closed
wants to merge 1 commit into from

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented Dec 11, 2018

Attempt to update history and react-router deps

Changes proposed in this Pull Request:

  • deps update

Testing instructions:

  • run yarn build, make sure it works
  • Launch JN site. click through & make sure it does not fails

Proposed changelog entry for your changes:

  • none

@brbrr brbrr self-assigned this Dec 11, 2018
@brbrr brbrr requested a review from a team December 11, 2018 07:11
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 59dc3d4

@brbrr
Copy link
Contributor Author

brbrr commented Dec 11, 2018

Seems like it's not easily archivable. react-router-redux is deprecated, and will not work with react-router v4.

library has been deprecated. It is recommended that you separate out Redux and React Router, as their state semantics don't match up exactly. But if you wish to attempt to keep them in sync, you can use a library such as connected-react-router.

Also, the migration guide not really straightforward (https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/guides/migrating.md)

Closing this and #10906

@brbrr brbrr closed this Dec 11, 2018
@brbrr brbrr deleted the update/history-react-router-dependencies branch December 11, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants