Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicize: Remove Path UI #10156

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Publicize: Remove Path UI #10156

merged 2 commits into from
Sep 18, 2018

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 17, 2018

Partly fixes #10155.
Still needs Calypso ( Automattic/wp-calypso#27252 ) and backend.

Changes proposed in this Pull Request:

  • Remove Path UI

Testing instructions:

  • Visit Settings->Sharing in wp-admin with Publicize activated.
  • Confirm Path is no longer listed

Proposed changelog entry for your changes:

  • Removes Path as an option for Publicize since that service is closing October 2018.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Status] In Progress labels Sep 17, 2018
@kraftbj kraftbj requested a review from a team as a code owner September 17, 2018 18:30
@jetpackbot
Copy link

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@kraftbj
Copy link
Contributor Author

kraftbj commented Sep 17, 2018

Before:
path-before

After:
path-after

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Sep 17, 2018
@kraftbj kraftbj added this to the 6.6 milestone Sep 17, 2018
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 18, 2018
jeherve
jeherve approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and seems to work well. I also tested it on a site that had an active connection to Path, and did not notice any issues.

I just removed a few more mentions of Path, but other than that we should be all set! 👍

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18453-code. (newly created revision)

@kraftbj
Copy link
Contributor Author

kraftbj commented Sep 18, 2018

Nice catch! Thanks.

@kraftbj kraftbj merged commit 6be65f6 into master Sep 18, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 18, 2018
@kraftbj kraftbj deleted the remove/path branch September 18, 2018 13:58
jeherve added a commit that referenced this pull request Sep 24, 2018
@jeherve
changelog: add #10156
3fe66fe
jeherve added a commit that referenced this pull request Sep 25, 2018
@jeherve
Changelog for 6.6 release (#10107)
581489a 
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
[Feature] Publicize Now Jetpack Social, auto-sharing Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.6
Development

Successfully merging this pull request may close these issues.

Publicize: Remove Path Connection & Sharing
4 participants
@kraftbj @jetpackbot @matticbot @jeherve