Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite Scroll: Privacy Policy link missing from footer #9435

Closed
iandunn opened this issue Apr 27, 2018 · 3 comments · Fixed by #9918
Closed

Infinite Scroll: Privacy Policy link missing from footer #9435

iandunn opened this issue Apr 27, 2018 · 3 comments · Fixed by #9918
Labels
[Feature] Infinite Scroll [Focus] GDPR Good For Community [Pri] High [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug

Comments

@iandunn
Copy link

iandunn commented Apr 27, 2018

WP 4.9.6 is adding an extra link to the footer on bundled themes, see #43715-core.

If a site has the the infinite footer enabled, though, then it will not appear.

It seems like it might be worth adding similar a similar link to $credits, to mimic the default themes, and help users be GDPR-compliant.

Steps to reproduce the issue

  1. Check out Core trunk (or 4.9.6-beta1 once it's available on Tuesday)
  2. Enable one of the bundled themes
  3. Create a page for the privacy policy text
  4. Set that page as the privacy policy page
  5. View the site, you'll see the privacy policy link in the footer
  6. Enable the Infinite Scroll module and the infinite footer
  7. Refresh the front end, and the privacy link will be gone

What I expected

The privacy link should remain, since it's important for GDPR compliance.

What happened instead

The link is gone, because the infinite footer is hardcoded.
@iandunn iandunn added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Infinite Scroll [Type] Good First Bug Good For Community [Focus] GDPR labels Apr 27, 2018
@jeherve jeherve added this to the 6.1 milestone Apr 28, 2018
@jeherve jeherve modified the milestones: 6.1, 6.1.1 May 2, 2018
@jeherve jeherve modified the milestones: 6.1.1, 6.2 May 23, 2018
@oskosk oskosk modified the milestones: 6.2, 6.3 Jun 6, 2018
@brbrr brbrr modified the milestones: 6.3, 6.4 Jul 2, 2018
@laghee
Copy link
Contributor

laghee commented Jul 11, 2018

Hi, all! I'm a wordpress noob and interested in filing a fix for this. After following the link above and poking around a bit on a local dev installation, it seems like tweaking default footer() to something like the following might work:

screenshot 2018-07-11 21 52 00

I'll work on figuring out php testing tomorrow, but it would be great if someone could tell me whether it looks like I'm on the right track so far. Thanks!

@zinigor
Copy link
Member

zinigor commented Jul 13, 2018

@laghee thanks for working on this! Your code seems to be a good solution, but it's hard to tell without looking at the diff and testing. Would you mind submitting a pull request? You can learn about how to do it here: https://github.com/Automattic/jetpack/blob/master/docs/guides/submit-patch.md

@laghee
Copy link
Contributor

laghee commented Jul 15, 2018

@zinigor Will do!

@laghee laghee mentioned this issue Jul 15, 2018
Merged
@oskosk oskosk modified the milestones: 6.4, 6.5 Aug 7, 2018
@oskosk oskosk removed this from the 6.5 milestone Aug 30, 2018
jeherve pushed a commit that referenced this issue Sep 7, 2018
@laghee @jeherve
Infinite Scroll: Add privacy policy link (#9918)
1b48b87 
Fixes #9435 

WP bundled themes now have a privacy policy link in their footer, which
is helpful for complying with GDPR rules, but users who enable the infinite
footer lose that link. This adds a similar link to the infinity footer $credits.

#### Changes proposed in this Pull Request:

* Add a privacy policy link to `$credits` to mimic the new WP bundled theme link

#### Testing instructions:

<!--
Add as many details as possible to help others reproduce the issue and test the fix.
"Before / After" screenshots can also be very helpful when the change is visual.

Would you like this feature to be tested by Beta testers as well?
Please add instructions to to-test.md in a new commit as part of your PR.
-->

* Publish the privacy policy page on test site
* Enable infinite scroll with this patch applied
* Scroll down to display the infinite footer
* Confirm that it now includes a link to the privacy policy page

(Edit: Added extra step for testing.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Infinite Scroll [Focus] GDPR Good For Community [Pri] High [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infinite Scroll: Add privacy policy link laghee/jetpack
6 participants
@zinigor @jeherve @iandunn @oskosk @brbrr @laghee