-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg 7.7.1/7.8: Simple Payments Block is removed if pasting into the email field #15121
Gutenberg 7.7.1/7.8: Simple Payments Block is removed if pasting into the email field #15121
Comments
The problem is caused by the fact that Gutenberg is using the |
Related: #11906 |
Should we temporarily make the field |
The only other way I could see to fix in wpcom/jetpack ahead of a fix in gutenberg was to trap the copy/cut/paste events on the email field and stop propogation - PR doing this here - but this is much more heavy handed than just changing the email field to |
@simison & @jeherve - what are your thoughts on trapping the events versus changing field type to text as a temporary fix on wpcom/jetpack. Trapping the events was an interesting exercise and may be useful to inform a solution in gutenberg that allows passing an extra prop to |
Type text sounds better because of simplicity. Type email doesn't sound
that critical anyway?
…On Fri, 27 Mar 2020, 05:32 Glen Davies, ***@***.***> wrote:
@simison <https://github.com/simison> & @jeherve
<https://github.com/jeherve> - what are your thoughts on trapping the
events <#15143> versus changing
field type to text <#15145> as
a temporary fix on wpcom/jetpack.
Trapping the events was an interesting exercise and may be useful to
inform a solution in gutenberg that allows passing an extra prop to
TextControl to indicate if native copy/paste should be preserved ... but
it is probably overkill as a temporary fix. The field type change fixes the
issue and email validation still works.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15121 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVJAG2G6CZRPXPL2U63VLRJQM6HANCNFSM4LTX5MRA>
.
|
Agreed, let's go with this for now. |
Describe the bug
A clear and concise description of what the bug is.
To reproduce
Steps to reproduce the behavior:
Expected behavior
The text should be pasted into the field
Screenshots
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: