Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo-location: improve display of xmlns:georss attribute #12051

Closed
jeherve opened this issue Apr 15, 2019 · 1 comment · Fixed by #13801
Closed

Geo-location: improve display of xmlns:georss attribute #12051

jeherve opened this issue Apr 15, 2019 · 1 comment · Fixed by #13801
Assignees
Labels
[Feature] Geo Location Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone

Comments

@jeherve
Copy link
Member

jeherve commented Apr 15, 2019

From #9885:

I think the solution could be improved. Currently the generated tag looks like this for me:

<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"
	xmlns:content="http://purl.org/rss/1.0/modules/content/"
	xmlns:wfw="http://wellformedweb.org/CommentAPI/"
	xmlns:dc="http://purl.org/dc/elements/1.1/"
	xmlns:atom="http://www.w3.org/2005/Atom"
	xmlns:sy="http://purl.org/rss/1.0/modules/syndication/"
	xmlns:slash="http://purl.org/rss/1.0/modules/slash/"
	
xmlns:georss="http://www.georss.org/georss" xmlns:geo="http://www.w3.org/2003/01/geo/wgs84_pos#"
>

Which I find to be suboptimal. xmlns:slash and xmlns:georss are now only separated by new line. All others are separated by new line plus a tab.
In my special case, the rss reader compresses the file by stripping line breaks and replacing 1+n tabs by a space. Which would work well with a document generated by simple_xml entirely as you can be sure there will be tabs in front of every sub-node.

So to insert safely into the generated document, I suggest to add a tab char in front of xmlns:georss.

cc @jbjhjm

@stale
Copy link

stale bot commented Oct 12, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Geo Location Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants