Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: show banner after first successful WordPress.com Secure Sign On login #10692

Closed
joanrho opened this issue Nov 21, 2018 · 3 comments · Fixed by #10979
Closed

Settings: show banner after first successful WordPress.com Secure Sign On login #10692

joanrho opened this issue Nov 21, 2018 · 3 comments · Fixed by #10979
Assignees
@joanrho @jeherve
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@joanrho
Copy link
Contributor

joanrho commented Nov 21, 2018 •
edited
Loading

After the WordPress.com Secure Sign On login module has been activated by a user, present the user with a banner in the Jetpack Dashboard view after their first time logging in with WordPress.com Secure Sign On to communicate the feature's value (that it’s a safer way to login).

ref: p6TEKc-2m8-p2 (RB / item 5.17)
@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Nov 21, 2018
@joanrho joanrho self-assigned this Dec 3, 2018
@joanrho joanrho changed the title Settings: add JITM after first successful WordPress.com login Settings: show banner after first successful WordPress.com login Dec 5, 2018
@joanrho
Copy link
Contributor Author

joanrho commented Dec 5, 2018 •
edited
Loading

Proposed solution:

Banner that appears the first time (only) a user signs in using WordPress.com Secure Sign On that informs them of the successful sign on, describes the benefit, and links to our support page with more details. Banner text will read:

Title: "You've successfully signed in with WordPress.com Secure Sign On!"
Description: "Logging in with the same log-in credentials you use for WordPress.com ensures you always sign in to self-hosted WordPress.org sites quickly and securely. Learn more"
where "Learn more" links to https://jetpack.com/support/sso/.

Mockup:
screen shot 2018-12-05 at 2 43 28 pm

Ready for development by @Automattic/jetpack-crew!

@joanrho joanrho changed the title Settings: show banner after first successful WordPress.com login Settings: show banner after first successful WordPress.com Secure Sign On login Dec 6, 2018
@jeherve jeherve self-assigned this Dec 12, 2018
@jeherve
Copy link
Member

jeherve commented Dec 12, 2018

I started working on this, and I would have some questions:

  • You modeled the design of the notice after the existing JITMs that can appear on all pages of the dashboard. I assume that if this SSO notice should replace any JITM displayed there?
  • Since we already have a tool to display notices in the dashboard, I was wondering if we could take advantage of that tool instead of building something new, or something that would override the JITMs. We could, for example, create a new JITM that would only be displayed on that main dashboard page, and only on sites where SSO is active. We could also choose to make it disappear after you dismiss it once. Here is how that would look like: D22220-code

The inconvenient of that second approach is that we lose a bit of flexibility: we can't display it "only after a login via SSO", and we can't "display it only once". On the other hand, we leverage an existing system, with its built-in stats and design, and we don't have any overhaul in the plugin.

What do you think?

@jeherve jeherve mentioned this issue Dec 14, 2018
Merged
jeherve added a commit that referenced this issue Dec 14, 2018
@jeherve
SSO: force the display of a JITM when someone first SSOs in
33e809e 
Fixes #10692

- At first SSO login, set an option
- If that option is true, display an SSO JITM.
- Once the SSO JITM has been displayed, set the option to false so it can never be displayed again
@jeherve
Copy link
Member

jeherve commented Dec 14, 2018

#10979 introduces an approach that would work, and is Jetpack-only, while not conflicting with other JITMs (no chance of having 2 JITMs displayed at the same time).

brbrr pushed a commit that referenced this issue Dec 18, 2018
@jeherve @brbrr
SSO: set option when someone sees a JITM helping them to discover SSO. (
5883358 
#10979)

* SSO: force the display of a JITM when someone first SSOs in

Fixes #10692

- At first SSO login, set an option
- If that option is true, display an SSO JITM.
- Once the SSO JITM has been displayed, set the option to false so it can never be displayed again

* Move JITM array building into its own function.

- Separates JITM building from the function that overwrites exisiting JITMs.
- Clean up and update comments.

* SSO JITM: update copy based on feedback.

see #10979 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanrho joanrho

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SSO: set option when someone sees a JITM helping them to discover SSO. Automattic/jetpack
3 participants
@kraftbj @joanrho @jeherve