Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Hide preview of Related Posts until module is activated #10691

Closed
joanrho opened this issue Nov 21, 2018 · 1 comment
Closed

Settings: Hide preview of Related Posts until module is activated #10691

joanrho opened this issue Nov 21, 2018 · 1 comment
Assignees
@joanrho @jeherve
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@joanrho
Copy link
Contributor

joanrho commented Nov 21, 2018 •
edited
Loading

In Settings > Traffic, hide preview of Related Posts until module is activated.

Perhaps we can also add a visual indicator to help make it more clear that you’re viewing a preview.

ref: p6TEKc-2m8-p2 (RB / item 5.16)
@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Admin Page React-powered dashboard under the Jetpack menu labels Nov 21, 2018
@joanrho joanrho self-assigned this Dec 3, 2018
@joanrho
Copy link
Contributor Author

joanrho commented Dec 3, 2018 •
edited
Loading

Proposed solution:

Hide preview until module is activated. Development help will be needed to set up the conditional logic for this. Update label text so it's clearer that it's a preview based on which toggles are switched on.

BEFORE:
before

AFTER:
Note: Preview is hidden until module is activated. Text label for preview is changed to "Preview" (instead of "Example").
after

Ready for development by @Automattic/jetpack-crew!

@jeherve jeherve self-assigned this Dec 12, 2018
jeherve added a commit that referenced this issue Dec 12, 2018
@jeherve
Admin Page: hide Related Posts preview when not active.
9ffde11 
Fixes #10691
@jeherve jeherve mentioned this issue Dec 12, 2018
Merged
jeherve added a commit that referenced this issue Dec 13, 2018
@jeherve
Admin Page: hide Related Posts preview when not active. (#10956)
ba4d5e8 
Fixes #10691

#### Changes proposed in this Pull Request:

* We now hide the Related Posts preview when the module is not active.

![screen recording 2018-12-12 at 12 01 pm](https://user-images.githubusercontent.com/426388/49865823-3eb35880-fe06-11e8-9bc5-4bcf4c6b8fef.gif)

#### Testing instructions:

* Go to Settings > Traffic
* Activate and deactivate the Related Posts module, and make sure the preview appearing below the toggles is updated accordingly.

#### Proposed changelog entry for your changes:

* Admin Page: hide Related Posts preview when not active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanrho joanrho

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joanrho @jeherve