Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Block Availability task list #10198

Closed
2 of 4 tasks
sirreal opened this issue Sep 24, 2018 · 4 comments
Closed
2 of 4 tasks

Gutenberg: Block Availability task list #10198

sirreal opened this issue Sep 24, 2018 · 4 comments
Assignees
@aldavigdis @roccotripaldi
Labels
Epic Formerly "Primary Issue", or "Master Issue" [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Type] Task

Comments

@sirreal
Copy link
Member

sirreal commented Sep 24, 2018 •
edited by jeherve
Loading

Individual development tasks from pafL3P-1X-p2
Related discussion: p1HpG7-5JG-p2

Tasks

  1. Do not register blocks when Jetpack is not connected (Gutenberg: Disable Jetpack blocks when disconnected #10195)
  2. Expose data about which blocks should be available based on modules (Gutenpack: Expose data for blocks #10327, WIP: Gutenpack availability wp-calypso#27875)
  3. Read and respect exposed block activation data
  4. Consider Jetpack development mode

Punted

  • Expose module API so blocks can query and update modules
  • Expose module data to blocks so they can behave accordingly.
    • Overridden deactivated modules are never registered.
    • When a block that depends on a module is inserted, it activates the corresponding module in the background.

@Automattic/luna @Automattic/poseidon
@sirreal sirreal added [Status] In Progress [Type] Task [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Sep 24, 2018
@jeherve jeherve added the Epic Formerly "Primary Issue", or "Master Issue" label Sep 24, 2018
@tyxla tyxla assigned tyxla and unassigned tyxla Sep 26, 2018
@jeherve jeherve added this to the 6.7 milestone Oct 11, 2018
@tyxla
Copy link
Member

tyxla commented Oct 12, 2018

Added a "Consider Jetpack development mode" item, as suggested by @jeherve in p1HpG7-5EW-p2 #comment-27930

@jeherve jeherve mentioned this issue Oct 15, 2018
Merged
@jeherve jeherve changed the title Gutenberg: Block Visibility task list Gutenberg: Block Availability task list Oct 15, 2018
This was referenced Oct 15, 2018
Closed
Closed
Closed
This was referenced Oct 16, 2018
Merged
Closed
@sirreal sirreal assigned aldavigdis and roccotripaldi and unassigned sirreal Oct 24, 2018
@jeherve jeherve modified the milestones: 6.7, 6.8 Oct 29, 2018
jeherve pushed a commit that referenced this issue Oct 30, 2018
@sirreal @jeherve
Gutenpack: Expose data for blocks (#10327)
bd3b021 
Closes #10243 (supersedes)
Part of #10198

Calypso (block) PR in progress: Automattic/wp-calypso#27875

This is the simplest way of reusing an existing data set to expose some required data for blocks to access.

#### Changes proposed in this Pull Request:

* Exposes `Jetpack_Initial_State` global. This is the same data used by the React-based dashboard/settings views

#### Testing instructions:

* Load the Gutenberg editor with Jetpack blocks available
* Observe the `Jetpack_Initial_State` global is available in the console
@jeherve jeherve mentioned this issue Nov 7, 2018
Merged
@aldavigdis aldavigdis mentioned this issue Nov 7, 2018
Closed
@aldavigdis
Copy link
Contributor

For reference, I just referred this ticket at #8764.

Just talked to @roccotripaldi and asked him for a sister global of the "available blocks" array for determining the WordPress.com or Jetpack plan in use, so we can facilitate the VideoPress block as well as other work.

This was referenced Nov 12, 2018
Merged
Closed
Closed
@jeherve jeherve removed this from the 6.8 milestone Nov 20, 2018
@sirreal
Copy link
Member Author

sirreal commented Nov 21, 2018

@roccotripaldi or @aldavigdis I think this is settled, shall we close?

@roccotripaldi
Copy link
Member

Yes, let's close it!
I'm tracking additional tasks on p1HpG7-5Nf-p2 for now, and i'll create additional Git issues as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldavigdis aldavigdis

@roccotripaldi roccotripaldi

Labels
Epic Formerly "Primary Issue", or "Master Issue" [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] High [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kraftbj @aldavigdis @jeherve @sirreal @roccotripaldi @tyxla