-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MailChimp Widget: Can't Convert Updated Popup Code #10104
Comments
Fixes #10104 Mailchimp updated their newsletter embed code, and the old one does not work anymore. This change matches the new format, and updates our test accordingly. Note that this also reverts the changes introduced in #8547, since they do not appear necessary anymore. Mailchimp fixed that issue on their end.
Thanks for your work on this @jeherve we also have a report of this on WP.com so commenting to make sure this fix gets backported :) |
Some additional testing information that might be helpful on this issue. Tested on a WordPress.com site with a Premium Plan and custom domain. The before code looked the same as referenced above.
Based on the suggested work-around of:
It was tested and worked on a couple of sites formatted as above, but didn't work on another site. Further testing resulted in it working when the single quotes were replaced with double quotes and it has worked formatted like this:
Wasn't sure if this could be useful, so wanted to share. :-) |
reported in #1413476-zen |
Fixes #10104 Mailchimp updated their newsletter embed code, and the old one does not work anymore. This change matches the new format, and updates our test accordingly. Note that this also reverts the changes introduced in #8547, since they do not appear necessary anymore. Mailchimp fixed that issue on their end.
Reported on #1432034-zen as well. |
* Shortcodes: update Mailchimp shortcode to match new format. Fixes #10104 Mailchimp updated their newsletter embed code, and the old one does not work anymore. This change matches the new format, and updates our test accordingly. Note that this also reverts the changes introduced in #8547, since they do not appear necessary anymore. Mailchimp fixed that issue on their end. * Update testing list to include steps for #10105
Related to #7945, Mailchimp changed their popup Javascript code again, and this causes the Mailchimp widget to not convert it correctly into the proper shortcode.
Previously, it looked like:
<script type="text/javascript" src="//downloads.mailchimp.com/js/signup-forms/popup/embed.js" data-dojo-config="usePlainJson: true, isDebug: false"></script><script type="text/javascript">require(["mojo/signup-forms/Loader"], function(L) { L.start({"baseUrl":"mc.us8.list-manage.com","uuid":"be06c2a596db91bfe4099fde8","lid":"b47399ad05"}) })</script>
Now, it looks like:
<script type="text/javascript" src="//downloads.mailchimp.com/js/signup-forms/popup/unique-methods/embed.js" data-dojo-config="usePlainJson: true, isDebug: false"></script><script type="text/javascript">window.dojoRequire(["mojo/signup-forms/Loader"], function(L) { L.start({"baseUrl":"mc.us8.list-manage.com","uuid":"be06c2a596db91bfe4099fde8","lid":"08cf5fa008","uniqueMethods":true}) })</script>
Saving the the above code doesn't convert into the shortcode, or result in the popup showing up on the site.
Note that the
src
value has changed with the additional/unique-methods/
subfolder,require
was changed towindow.dojoRequire
anduniqueMethods":true
was added at the end. A workaround back then was to simply change the src URL, but this time it doesn't work. Manually creating the shortcode with thebaseURL
,uuid
andlid
values still works, though.An update on this widget would be fantastic. Thank you in advance!
The text was updated successfully, but these errors were encountered: