Sharing: do not record stats if the stats module is disabled. (#10120)

Fixes #9678 When the Stats module is disabled, do not use any tracking pixel on pages using sharing buttons.
Automattic · Sep 17, 2018 · ff5e53e · ff5e53e
1 parent 97a669d
commit ff5e53e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/modules/sharedaddy/sharing-service.php b/modules/sharedaddy/sharing-service.php
@@ -613,9 +613,10 @@ function sharing_add_footer() {
 
 		wp_enqueue_script( 'sharing-js' );
 		$sharing_js_options = array(
-			'lang'   => get_base_recaptcha_lang_code(),
+			'lang'            => get_base_recaptcha_lang_code(),
 			/** This filter is documented in modules/sharedaddy/sharing-service.php */
-			'counts' => apply_filters( 'jetpack_sharing_counts', true ),
+			'counts'          => apply_filters( 'jetpack_sharing_counts', true ),
+			'is_stats_active' => Jetpack::is_module_active( 'stats' ),
 		);
 		wp_localize_script( 'sharing-js', 'sharing_js_options', $sharing_js_options );
 	}

diff --git a/modules/sharedaddy/sharing.js b/modules/sharedaddy/sharing.js
@@ -42,7 +42,9 @@ if ( sharing_js_options && sharing_js_options.counts ) {
 						jQuery.getScript( service_request );
 					}
 
-					WPCOMSharing.bump_sharing_count_stat( service );
+					if ( sharing_js_options.is_stats_active ) {
+						WPCOMSharing.bump_sharing_count_stat( service );
+					}
 				}
 
 				WPCOMSharing.done_urls[ id ] = true;