Skip to content

Commit

Permalink
[not verified] add comment for webpack change
Browse files Browse the repository at this point in the history
  • Loading branch information
kangzj committed Sep 22, 2021
1 parent 25b2ec9 commit e162fbb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions projects/plugins/jetpack/tools/webpack.config.search.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const baseWebpackConfig = getBaseWebpackConfig(
main: path.join( __dirname, '../modules/search/instant-search/loader.js' ),
},
// Putting a cache buster in the query string is not documented, but confirmed by the author of Webpack.
// `But better use the hash in filename and use no query parameter.`
// The reason probably is because it's not the best way to do cache busting.
// More information: https://github.com/webpack/webpack/issues/2329
'output-chunk-filename': 'jp-search.chunk-[name].min.js?ver=[contenthash]',
'output-filename': 'jp-search-[name].bundle.js',
Expand Down

0 comments on commit e162fbb

Please sign in to comment.