Skip to content

Commit

Permalink
Allow current node LTS 14.17.6
Browse files Browse the repository at this point in the history
This change proposes allowing use of node 14.17.6 (current node LTS version at time of writing) in addition to node 16.7.0 which is what the project currently specifies in its node engines attribute.

`.nvmrc` will still point to 16.7.0, but the project can now be used in environments such as Gutenberg Mobile which are using node 14.17.6 LTS.

Co-authored-by: David Calhoun <[email protected]>
  • Loading branch information
guarani and dcalhoun committed Sep 8, 2021
1 parent 0ab796a commit 6e15620
Show file tree
Hide file tree
Showing 38 changed files with 86 additions and 22 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"jetpack-js-tools": "workspace:*"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/github-actions/repo-gardening/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"build": "ncc build src/index.js -o dist --source-map --license licenses.txt"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/github-actions/required-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"build": "ncc build src/main.js -o dist --source-map --license licenses.txt"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/api/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"test": "NODE_ENV=test NODE_PATH=tests:. js-test-runner --jsdom --initfile=test-main.jsx 'glob:./test/*.jsx'"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/base-styles/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/base-styles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@wordpress/base-styles": "3.6.0"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/components/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"test": "NODE_ENV=test NODE_PATH=tests:. js-test-runner --jsdom --initfile=test-main.jsx 'glob:./!(node_modules)/**/test/*.jsx'"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/connection/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/connection/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"test": "NODE_ENV=test NODE_PATH=tests:. js-test-runner --jsdom --initfile=test-main.jsx 'glob:./!(node_modules)/**/test/*.jsx'"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/eslint-changed/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"eslint": ">=1.1.0"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/js-packages/storybook/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/js-packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"webpack": "5.51.1"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/connection-ui/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/packages/connection-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"jest": "27.0.4"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/identity-crisis/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/packages/identity-crisis/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"sass": "1.38.1"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/jitm/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/packages/jitm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"webpack-cli": "4.8.0"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/lazy-images/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/packages/lazy-images/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"webpack": "5.51.1"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/backup/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/plugins/backup/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"webpack": "5.51.1"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/boost/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/plugins/boost/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
},
"homepage": "https://jetpack.com/boost/",
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/plugins/jetpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
"react-dom": "17.0.2"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
2 changes: 1 addition & 1 deletion projects/plugins/jetpack/tests/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"yargs": "16.2.0"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
},
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/search/changelog/try-allow-node-14
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Allow Node ^14.17.6 to be used in this project. This shouldn't change the behavior of the code itself.
2 changes: 1 addition & 1 deletion projects/plugins/search/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"devDependencies": {},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"yargs-parser": "20.2.4"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/skeletons/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"devDependencies": {},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
2 changes: 1 addition & 1 deletion tools/js-test-runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"sinon-chai": "3.5.0"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down
2 changes: 1 addition & 1 deletion tools/js-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"yaml": "1.10.2"
},
"engines": {
"node": "^16.7.0",
"node": "^14.17.6 || ^16.7.0",
"pnpm": "^6.5.0",
"yarn": "use pnpm instead - see docs/yarn-upgrade.md"
}
Expand Down

0 comments on commit 6e15620

Please sign in to comment.