fix(core): AnA linter did not recognize capital articles
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 29, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | patch | `v0.18.0` -> `v0.18.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.18.1`](https://github.com/Automattic/harper/releases/tag/v0.18.1) [Compare Source](Automattic/harper@v0.18.0...v0.18.1) #### What's Changed - build(deps): bump [@​sveltepress/theme-default](https://github.com/sveltepress/theme-default) from 5.0.5 to 5.0.7 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#519 - build(deps-dev): bump eslint-config-prettier from 9.1.0 to 10.0.1 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#518 - build(deps-dev): bump vite-plugin-top-level-await from 1.4.1 to 1.4.4 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#516 - build(deps-dev): bump esbuild from 0.20.2 to 0.24.2 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#517 - build(deps-dev): bump flowbite from 1.8.1 to 3.0.0 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#515 - technical terms and popular names/websites by [@​MohamedAbdeen21](https://github.com/MohamedAbdeen21) in Automattic/harper#522 - fix(core): `AnA` linter did not recognize capital articles by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#521 - use unicode_script crate to check chars are Latin script inside `is_english_lingual` by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#504 - sort and add to list of holidays by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#509 - fix(core): `RepeatedWords` now detects repeated `and` tokens by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#520 - `harper-core` Documentation Updates by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#513 - feat: improve workflow for harper.js by [@​Asuka109](https://github.com/Asuka109) in Automattic/harper#526 - Add more languages by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#495 #### New Contributors - [@​MohamedAbdeen21](https://github.com/MohamedAbdeen21) made their first contribution in Automattic/harper#522 - [@​Asuka109](https://github.com/Asuka109) made their first contribution in Automattic/harper#526 **Full Changelog**: Automattic/harper@v0.18.0...v0.18.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMiIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
AnAlinter did not detect the problem in:This PR allows the rule to detect capital articles, thus allowing it to detect the error.