Skip to content
This repository has been archived by the owner on Jan 9, 2019. It is now read-only.

Loosen peers to allow for v3 of eslint #12

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Conversation

samouri
Copy link
Contributor

@samouri samouri commented Oct 27, 2017

See b6a59ff

can we make it compatible with both v3 and v4 instead? wp-calypso is currently blocked from using v4 do to: Automattic/wp-calypso#18106

@samouri samouri requested a review from aduth October 27, 2017 15:37
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this should be fine in its current form, I don't want to maintain support for eslint-plugin-wpcalypso in perpetuity since we may introduce rules into this config that depend on a newer version of the plugin. Since that's not the case and 4.x was a peer dependency upgrade on ESLint, there should not be an issue to use this as a temporary resolution until babel-eslint improves its support for ESLint 4.x.

@samouri samouri merged commit fdc552f into master Oct 30, 2017
@samouri samouri deleted the update/loosen-peers branch October 30, 2017 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants