Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullability Annotations to Java Classes] Add wordpress-lint Dependency #28

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Oct 24, 2023

This PR adds the org.wordpress:lint dependency to the catalog (2.0.0).

FYI: For more context on why this was done see FluxC's #2827 PR.


To test (via FluxC PR):

  1. Based on this commit, verify that all the CI checks are successful.
  2. Smoke test the example app.

@ParaskP7 ParaskP7 added the enhancement New feature or request label Oct 24, 2023
ParaskP7 added a commit to wordpress-mobile/WordPress-FluxC-Android that referenced this pull request Oct 24, 2023
FYI: This change was done for testing purposes and until the below
'Android Dependency Catalog' #28 PR gets merged to 'trunk'. When that's
done, the 'catalogVersion' will be updated to '1.15.0' instead.

PR: Automattic/android-dependency-catalog#28
@ParaskP7 ParaskP7 requested a review from wzieba October 24, 2023 11:22
Copy link
Member

@wzieba wzieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ParaskP7 ParaskP7 merged commit 36f5b3d into trunk Oct 25, 2023
2 checks passed
@ParaskP7 ParaskP7 deleted the deps/add-wordpress-lint-dependency branch October 25, 2023 10:06
wzieba pushed a commit to wordpress-mobile/WordPress-Android that referenced this pull request Oct 22, 2024
FYI: This change was done for testing purposes and until the below
'Android Dependency Catalog' #28 PR gets merged to 'trunk'. When that's
done, the 'catalogVersion' will be updated to '1.15.0' instead.

PR: Automattic/android-dependency-catalog#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants