Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable WordPress.Security.EscapeOutput.ExceptionNotEscaped #824

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Disable WordPress.Security.EscapeOutput.ExceptionNotEscaped #824

merged 1 commit into from
Jul 31, 2024

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Jul 31, 2024 •
edited
Loading

This ruleset is disabled by several teams already, so we should just disable it due to its controversy as we've discussed internally.

For example, this triggers it:

throw new InvalidArgumentException( __( 'Bad request.', 'two-factor-provider-webauthn' ) );

@rebeccahum rebeccahum requested a review from a team as a code owner July 31, 2024 18:39
@rebeccahum rebeccahum merged commit 72ec09b into develop Jul 31, 2024
38 of 40 checks passed
@rebeccahum rebeccahum deleted the rm/WordPress-security branch July 31, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gudmdharalds gudmdharalds gudmdharalds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @gudmdharalds