Switch to PHPCSStandards/PHP_CodeSniffer & raise minimum supported version #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
4 times, most recently
from
6907519 to
62b9e9c
Compare
This was referenced Dec 4, 2023
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation. Ref: * squizlabs/PHP_CodeSniffer 3932
... for improved PHP 8.2 support.
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
62b9e9c to
bf5c613
Compare
|
Update: The Composer package name will not change, so while this PR should still be merged at our convenience (after the 3.8.0 release, expected this Friday), we will not need to do a release to unblock end-users. |
|
PHPCS 3.8.0 has been released. (as well as PHPCSUtils 1.0.9 + PHPCSExtra 1.2.1) Marking this PR as ready for review and retriggering the builds. |
|
Oh, and I will also remove the changelog commit from this PR as, now the Composer package name doesn't change, tagging a new release is not that urgent. |
... after the tooling has also updated to the PHPCSStandards version of PHPCS. Refs: * https://github.com/PHPCSStandards/PHPCSUtils/releases * https://github.com/PHPCSStandards/PHPCSExtra/releases
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
bf5c613 to
873e28e
Compare
GaryJones
approved these changes
Dec 8, 2023
|
Just checking - any reason why this PR hasn't been merged yet ? |
|
Nope, no reason. |
|
Is it time to merge it maybe ? Asking again as there is another PR waiting on this one (which makes the test suite compatible with PHPUnit 8 + 9). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which contains the Composerand the other dependencies have released, this can/should be mergedreplacedirective)and released ASAP.Switch to PHPCSStandards/PHP_CodeSniffer
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.
Ref:
Composer: raise the minimum supported PHPCS version to 3.8.0
... for improved PHP 8.2 support.
... to prevent end-users from running into trouble with the name change.The files in the Composervendor/binwill only be replaced when thereplace...directive is found and that is only available in the 3.8.0 tag.When the files in the Composervendor/binare not replaced, they will continue to point to thevendor/squizlabs/php_codesnifferdirectory which will no longer exist, leading to fatal "File not found" errors for end-users trying to run PHPCS/PHPCBF.Includes updating references to the PHPCS version whenever relevant throughout the codebase.
Composer: update various version constraints
... after the tooling has also updated to the PHPCSStandards version of PHPCS.
Refs:
Changelog for the release of version 3.0.1Closes #804