RestrictedVariables: don't report on "use" in isset()
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this reminds me that I should open a review issue for the abstract sniff ;-) |
jrfnl
force-pushed
the
fix/568-restrictedvariable-disregard-when-in-isset-or-empty
branch
2 times, most recently
from
f69245a to
b54105f
Compare
Disregard when the existence of a restricted variable is being checked. This uses the upstream WPCS `Sniff::is_in_isset_or_empty()` method.
This means that variables will not be reported as "used" when they are wrapped in a call to:
* `isset()`
* `empty()`
* `array_key_exists()`
This also means that the `if ( isset( $_SERVER['REMOTE_ADDR'] ) ) {` test on line 13 will no longer report a warning.
As `$_SERVER['REMOTE_ADDR']` was then no longer tested for and `$_SERVER['HTTP_USER_AGENT']` was being tested twice (line 14 and line 28), I've changed the occurrence on line 14 to use `$_SERVER['REMOTE_ADDR']` to make sure both are still tested.
Includes additional unit test for the case as reported by the op.
Fixes 568
GaryJones
approved these changes
Jul 30, 2020
GaryJones
deleted the
fix/568-restrictedvariable-disregard-when-in-isset-or-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disregard when the existence of a restricted variable is being checked. This uses the upstream WPCS
Sniff::is_in_isset_or_empty()method.This means that variables will not be reported as "used" when they are wrapped in a call to:
isset()empty()array_key_exists()This also means that the
if ( isset( $_SERVER['REMOTE_ADDR'] ) ) {test on line 13 will no longer report a warning.As
$_SERVER['REMOTE_ADDR']was then no longer tested for and$_SERVER['HTTP_USER_AGENT']was being tested twice (line 14 and line 28), I've changed the occurrence on line 14 to use$_SERVER['REMOTE_ADDR']to make sure both are still tested.Includes additional unit test for the case as reported by the op.
Fixes #568