Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables/RestrictedVariables: fix namespace of unit test file + fix test #559

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Variables/RestrictedVariables: fix namespace of unit test file + fix test #559

merged 2 commits into from
Jul 27, 2020

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jul 27, 2020

  • The namespace of the test file was not for VIPCS.
  • Update the inline exclude property setting syntax.

jrfnl added 2 commits July 27, 2020 22:23
@jrfnl
Variables/RestrictedVariables: fix namespace of unit test file
3e03066
@jrfnl
Variables/RestrictedVariables: fix the test
bc780bb 
Now the test is actually running under the proper namespace, it comes to light that the test for the `exclude` property is not working as it is using an outdated syntax.

Fixed now.
@jrfnl jrfnl added this to the 2.2.0 milestone Jul 27, 2020
@jrfnl jrfnl requested a review from a team as a code owner July 27, 2020 20:52
@GaryJones GaryJones merged commit 4d644cb into develop Jul 27, 2020
@GaryJones GaryJones deleted the fix/restrictedvariables-tests-incorrect-namespace branch July 27, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @GaryJones