DeclarationCompatibility: fix incorrect signature check for Walker::walk()
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…walk()` ... and `Walker::paged_walk()`. The method signature of both the `Walker::walk()` method as well as the `Walker::paged_walk()` method were changed in WordPress 5.3 to make the variadic nature of the allowed arguments explicit. This changes update the sniff to verify the signature of these methods in child classes against the new method signature as it is in WordPress Core. Refs: * https://make.wordpress.org/core/2019/10/09/wp-5-3-introducing-the-spread-operator/ * https://core.trac.wordpress.org/changeset/46442 Fixes 448
GaryJones
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and
Walker::paged_walk().The method signature of both the
Walker::walk()method as well as theWalker::paged_walk()method were changed in WordPress 5.3 to make the variadic nature of the allowed arguments explicit.This change updates the sniff to verify the signature of these methods in child classes against the new method signature as it is in WordPress Core.
Refs:
Fixes #448
Note: I've pointedly ignored everything else which could be improved in this sniff and just focused on getting this particular issue fixed for now.