Travis: Expand supported PHP down to 5.4 #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 5.4 is the minimum that PHPCS and WPCS support, so it would be nice to be able to say VIPCS supports the same minimum version of PHP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.4 is the minimum that PHPCS and WPCS support, so it would be nice to be able to say VIPCS supports the same minimum version of PHP.
As much as I'd love to use some PHP 7-only syntax in sniffs, that doesn't seem like a good enough reason to limit what versions of PHP we support for using this tool (it doesn't affect what versions of PHP that themes and plugins use of course).