Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review minimum-stability #562

Closed
GaryJones opened this issue Jul 27, 2020 · 1 comment · Fixed by #573
Closed

Review minimum-stability #562

GaryJones opened this issue Jul 27, 2020 · 1 comment · Fixed by #573
Assignees
@jrfnl
Labels
Type: Maintenance
Milestone
2.2.0

Comments

@GaryJones
Copy link
Contributor

The minimum-stability value in the composer.json file is RC.

We should review if that's still needed, and if not, move it to stable.

May wait to see when exactly it makes sense to add PHPCSUtils as a require dependency i.e. 1.0.0-RC.
@GaryJones GaryJones added this to the 2.2.0 milestone Jul 27, 2020
@jrfnl
Copy link
Collaborator

jrfnl commented Jul 27, 2020

IMO: leave it alone, it's not that relevant. It only applies to this project anyway, not to projects require-ing this project. (It's a root-only setting)

https://getcomposer.org/doc/04-schema.md#minimum-stability

GaryJones added a commit that referenced this issue Aug 29, 2020
@GaryJones
Composer: Change minimum stability to stable
307db72 
We don't require or require-dev any packages that are not stable, so no need to continue allowing RC at this time.

Fixes #562.
@GaryJones GaryJones mentioned this issue Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrfnl jrfnl

Labels
Type: Maintenance
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Composer: Change minimum stability to stable Automattic/VIP-Coding-Standards
2 participants
@GaryJones @jrfnl