Merge pull request #812 from Automattic/fix/remove-term-exists-error

End restricting usage of term_exists()
Automattic · Feb 16, 2024 · f2a6b2e · f2a6b2e
2 parents b8a8877 + cd82f3e
commit f2a6b2e
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 14 deletions.
diff --git a/WordPress-VIP-Go/ruleset-test.inc b/WordPress-VIP-Go/ruleset-test.inc
@@ -358,7 +358,7 @@ wpcom_vip_irc(); // Error.
 flush_rewrite_rules(); // Error.
 $wp_rewrite->flush_rules(); // Error.
 \add_role(); // Error.
-term_exists(); // Error.
+
 count_user_posts(); // Error.
 get_intermediate_image_sizes(); // Error.
 wp_is_mobile(); // Error.

diff --git a/WordPress-VIP-Go/ruleset-test.php b/WordPress-VIP-Go/ruleset-test.php
@@ -47,7 +47,6 @@
 		358 => 1,
 		359 => 1,
 		360 => 1,
-		361 => 1,
 		362 => 1,
 		363 => 1,
 		364 => 1,

diff --git a/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php b/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php
@@ -102,13 +102,6 @@ public function getGroups() {
 					'add_role',
 				],
 			],
-			'term_exists' => [
-				'type'      => 'error',
-				'message'   => '%s() is highly discouraged due to not being cached; please use wpcom_vip_term_exists() instead.',
-				'functions' => [
-					'term_exists',
-				],
-			],
 			'count_user_posts' => [
 				'type'      => 'error',
 				'message'   => '%s() is highly discouraged due to not being cached; please use wpcom_vip_count_user_posts() instead.',

diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc
@@ -84,8 +84,8 @@ add_role( 'test' ); // Error.
 
 
 
-wpcom_vip_term_exists(); // Ok - VIP recommended version of term_exists().
-term_exists(); // Error.
+
+
 
 wpcom_vip_count_user_posts(); // Ok - VIP recommended version of count_user_posts().
 count_user_posts(); // Error.

diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php
@@ -39,7 +39,6 @@ public function getErrorList() {
 			62  => 1,
 			75  => 1,
 			76  => 1,
-			88  => 1,
 			91  => 1,
 			94  => 1,
 			97  => 1,

diff --git a/WordPressVIPMinimum/ruleset-test.inc b/WordPressVIPMinimum/ruleset-test.inc
@@ -329,7 +329,7 @@ url_to_postid( $url ); // Error.
 
 
 
-term_exists(); // Error.
+
 count_user_posts(); // Error.
 wp_old_slug_redirect(); // Error.
 get_adjacent_post(); // Error.

diff --git a/WordPressVIPMinimum/ruleset-test.php b/WordPressVIPMinimum/ruleset-test.php
@@ -95,7 +95,6 @@
 		325 => 1,
 		326 => 1,
 		327 => 1,
-		332 => 1,
 		333 => 1,
 		334 => 1,
 		335 => 1,
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,7 +47,6 @@ @@
 => 1,
 => 1,
 => 1,
-=> 1,
 => 1,
 => 1,
 => 1,
@@ Expand Down @@