-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.0.0 rc1 #369
Release/2.0.0 rc1 #369
Conversation
@@ -54,7 +54,7 @@ apiValidation { | |||
} | |||
|
|||
// Semantic versioning for release version | |||
val versionName = "1.1.0" | |||
val versionName = "2.0.0-rc1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this if we use git to check tag anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for docs generation. The tag is created after this PR.
I haven't created this flow but I can look into it some time.
I see - it's because by default, GitHub actions checkout action doesn't fetch tags and has depth of 1. I propose fix here: in #370, please merge this to this branch or trunk and rebase this branch - everything should work fine then. Or we can merge this if you prefer, as Submit dependencies failure shouldn't block release. Please, consider using a separate branch for storing generated documentation. The current diff is not really readable, and if I fetch the repository, I don't want to fetch the complete, generated documentation in HTML. |
Actually, I can't even comment on the PR because Google Chrome is crashing every time 😓 . My question for the PR - do we need to update |
Use dependency submission action
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I agree. We need to rethink how to manage the documentation. I've created a ticket #371 |
Description
2.0.0 release candidate 🎉
Testing Steps
Smoke test won't hurt?