Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.0.0 rc1 #369

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Release/2.0.0 rc1 #369

merged 7 commits into from
Oct 9, 2024

Conversation

AdamGrzybkowski
Copy link
Contributor

Description

2.0.0 release candidate 🎉

Testing Steps

Smoke test won't hurt?

@AdamGrzybkowski AdamGrzybkowski added this to the 2.0.0 milestone Oct 8, 2024
@AdamGrzybkowski
Copy link
Contributor Author

@wzieba The "submit dependencies" step from Github Actions fails here. Do you have any idea why is this happening?

@@ -54,7 +54,7 @@ apiValidation {
}

// Semantic versioning for release version
val versionName = "1.1.0"
val versionName = "2.0.0-rc1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if we use git to check tag anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for docs generation. The tag is created after this PR.
I haven't created this flow but I can look into it some time.

@wzieba
Copy link
Member

wzieba commented Oct 8, 2024

I see - it's because by default, GitHub actions checkout action doesn't fetch tags and has depth of 1. I propose fix here: in #370, please merge this to this branch or trunk and rebase this branch - everything should work fine then. Or we can merge this if you prefer, as Submit dependencies failure shouldn't block release.


Please, consider using a separate branch for storing generated documentation. The current diff is not really readable, and if I fetch the repository, I don't want to fetch the complete, generated documentation in HTML.

@wzieba
Copy link
Member

wzieba commented Oct 8, 2024

Actually, I can't even comment on the PR because Google Chrome is crashing every time 😓 . My question for the PR - do we need to update versionName if we use git tag to determine version anyway?

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 8, 2024

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commitbd38a27
Direct Downloadgravatar-demo-prototype-build-pr369-bd38a27.apk

Copy link
Contributor

@hamorillo hamorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hamorillo
Copy link
Contributor

hamorillo commented Oct 9, 2024

Please, consider using a separate branch for storing generated documentation. The current diff is not really readable, and if I fetch the repository, I don't want to fetch the complete, generated documentation in HTML.

I agree. We need to rethink how to manage the documentation. I've created a ticket #371

@AdamGrzybkowski AdamGrzybkowski merged commit eed1d1b into trunk Oct 9, 2024
17 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the release/2.0.0-rc1 branch October 9, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants