Build home_url() previews with trailing slash #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`home_url()` will only add a trailing slash to a site's home URL if a path is passed as an argument. If no path is passed, a page preview could be something like: http://wp.wsu.dev?page_id=1 And it would work fine in most cases. In a subdirectory multisite configuration, a page preview could be something like: http://wp.wsu.dev/site?page_id=1 This could be processed by WordPress as a lookup for a page named "site" rather than a site with that URL because no trailing slash exists. When adding query args to `home_url()`, we should tell it to use a slash to avoid confusion. See `_get_page_link()` for how core builds these in a way where a slash is always added.
jeremyfelt
added a commit
to washingtonstateuniversity/WSUWP-Build-Plugins-Public
that referenced
this pull request
Jul 27, 2016
Open pull request: Automattic/Edit-Flow#357
|
Awesome! Makes sense. Can you add a test to make sure this function returns the preview link correctly for both single and multisite installs? Tests should be passing again with this most recent commit. |
|
Just following up. Think you'll have some time to write a test for this patch? Would definitely be great to see one for edit: clarification |
|
Yep, I spaced on this a couple times. I'll have some time to add tests soon. :) |
|
@jeremyfelt sounds good! |
|
Just circling back on this. Think you'll have time to wrap it up with a small test? |
sboisvert
approved these changes
Feb 5, 2018
|
Marked for 0.8.3 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
home_url()will only add a trailing slash to a site's home URL if a path is passed as an argument.If no path is passed, a page preview could be something like:
http://wp.wsu.dev?page_id=1And it would work fine in most cases.
In a subdirectory multisite configuration, a page preview could be something like:
http://wp.wsu.dev/site?page_id=1This could be processed by WordPress as a lookup for a page named "site" rather than a site with that URL because no trailing slash exists.
When adding query args to
home_url(), we should tell it to use a slash to avoid confusion.See
_get_page_link()for how core builds these in a way where a slash is always added.See also #344, which I believe this fixes.