Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions #155

Merged
merged 15 commits into from
Sep 2, 2024
Merged

Conditions #155

merged 15 commits into from
Sep 2, 2024

Conversation

SimpleSquirrelz
Copy link
Collaborator

No description provided.

Copy link

socket-security bot commented Aug 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, filesystem Transitive: eval, shell, unsafe +80 11.1 MB SDisPater
pypi/[email protected] eval, filesystem 0 481 kB iharsuvorau, pix
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 1.51 MB abn, finswimmer, neersighted, ...1 more
pypi/[email protected] environment, eval, filesystem 0 370 kB ihalenok, pix
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 3.96 MB samuelcolvin
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.5 MB AWhetter, BryceGuinta, Claudiu.Popa, ...6 more
pypi/[email protected] environment, filesystem, shell Transitive: eval, network, unsafe +32 13 MB ionel
pypi/[email protected] environment, eval, filesystem, network, shell 0 237 kB ionel
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe +4 8.39 MB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, shell 0 160 kB bbc, theskumar
pypi/[email protected] filesystem 0 137 kB Kludex, andrew_d, tomchristie
pypi/[email protected] environment, filesystem, unsafe 0 1.05 MB stub
pypi/[email protected] environment, eval, filesystem, network 0 3.67 MB ingy, nitzmahone, tinita
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 477 kB Lukasa, graffatcolmingov, nateprewitt
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 151 MB matthew.brett, pv, rgommers, ...3 more
pypi/[email protected] environment, eval, filesystem Transitive: network, shell, unsafe +233 1.33 GB mwaskom
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.32 MB abravalheri, dstufft, jaraco
pypi/[email protected] environment, eval, filesystem, network, shell 0 812 kB embray, jiffyclub
pypi/[email protected] filesystem 0 26.5 kB digitalemagine
pypi/[email protected] environment, eval, filesystem, network, shell 0 568 kB casper.dcl, tqdm
pypi/[email protected] filesystem, network, shell 0 151 kB martinblech

🚮 Removed packages: pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected]), pypi/[email protected])

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.49153% with 31 lines in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (aaa478d) to head (f18ed01).

Files with missing lines Patch % Lines
src/simod/control_flow/optimizer.py 38.46% 8 Missing ⚠️
src/simod/branch_rules/discovery.py 64.70% 6 Missing ⚠️
src/simod/data_attributes/types.py 95.31% 3 Missing ⚠️
src/simod/simod.py 75.00% 3 Missing ⚠️
tests/test_data_attributes/test_discovery.py 93.87% 3 Missing ⚠️
src/simod/branch_rules/types.py 90.00% 2 Missing ⚠️
src/simod/settings/control_flow_settings.py 75.00% 2 Missing ⚠️
src/simod/settings/simod_settings.py 86.66% 2 Missing ⚠️
src/simod/control_flow/settings.py 75.00% 1 Missing ⚠️
src/simod/simulation/parameters/BPS_model.py 94.44% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   86.82%   86.98%   +0.16%     
==========================================
  Files          52       56       +4     
  Lines        2428     2651     +223     
==========================================
+ Hits         2108     2306     +198     
- Misses        320      345      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SimpleSquirrelz and others added 3 commits August 27, 2024 15:51
- New version, when stable, is going to be 5.0.0 as we added new functionalities like gateway rules.
- Updated configuration versioning to 5
- Implemented legacy converter to translate v4 into v5 format
@david-chapela
Copy link
Collaborator

@SimpleSquirrelz I checked the test in local, if I run it on its own it sometimes fails because it doesn't discover any global attribute (it's expecting 1).

def test_discover_global_attributes(entry_point, global_log_files):
    for log_path in global_log_files:
        log = pd.read_csv(log_path, compression="gzip")
        assert_attributes(log, LOG_IDS, expected_case_attrs=0, expected_event_attrs=16, expected_global_attrs=1)

Plz, change the input log to one simple log that has a global attribute easy to detect, so tests success doesn't depend on potential stochasticity in the discovery.

Copy link

@david-chapela david-chapela merged commit 7202b09 into master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants