Bugfix: correct array dimension in transform check #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这是来自QQ邮箱的假期自动回复邮件。你好，我（yyx）已收到邮件，感谢您的来信！
|
JoeLambourne
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR corrects a bug in an array comparison in the
Shape.transformmethod.Two regression smoke tests are also added to ensure this method runs through.
Why?
In the
Shape.transformmethod, a comparison is performed to check for the identity transform. Currently, this has mismatching dimensions with the expected transform array resulting in the following error:This renders this method unusable.