add autofill command

[Sneezry]

#829

[codecov]

Codecov Report

Merging #831 (31d6d9d) into dev (05dbda0) will decrease coverage by 0.20%.
The diff coverage is 13.11%.

@@            Coverage Diff             @@
##              dev     #831      +/-   ##
==========================================
- Coverage   18.34%   18.13%   -0.21%     
==========================================
  Files          17       18       +1     
  Lines        1543     1544       +1     
  Branches      337      338       +1     
==========================================
- Hits          283      280       -3     
- Misses       1226     1230       +4     
  Partials       34       34              

Impacted Files	Coverage Δ
src/utils.ts	11.86% <11.86%> (ø)
src/store/Accounts.ts	7.92% <50.00%> (-1.90%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05dbda0...31d6d9d. Read the comment docs.

[mymindstorm]

So, the reason we didn't implement this before was because we don't have secure website matching like the password managers do. We can't be sure that a website will not intentionally trick our auto fill matching and pretend to be a legitimate website. Do you think that is a big enough issue to not implement this feature?

[Sneezry]

So, the reason we didn't implement this before was because we don't have secure website matching like the password managers do. We can't be sure that a website will not intentionally trick our auto fill matching and pretend to be a legitimate website. Do you think that is a big enough issue to not implement this feature?

The current design is if there is only one matched account, autofill command will fill the code, or nothing happens. I don't think it's a big problem because in most cases, there's only one matched account. Smart filter works well, and secure website matching is not so important. FYI, this PR is for this feedback #829

[philippthiele]

I am a little confused, my authenticator extension already has such an option, I enabled it to use autofill, but it doesn't do anything. Now I see here it is not really merged yet. What does the current autofill option do?

EDIT:
Oh I see now, I had to restart chrome and now when I click the code it autofills. Sorry for the too quick question. But I will be very interested to see this feature here merged, I think it is a good addition, since I already thought this is what it is doing with the current autofill.

[mymindstorm]

matchedEntries.length <= 1

[Sneezry]

if matchedEntries.length == 0, const entry = matchedEntries[0] will be undefined. We should auto fill code when there is only one matched entry

[mymindstorm]

Sorry, incorrect logic on my end. I meant matchedEntries.length >= 1. It won't past a code if there is more than one match.

[Sneezry]

If there is more than one matched entry I think we should always ask the user to choose the correct one, but not the first one. What do you think?

[mymindstorm]

I agree, that would be the best solution.